Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the Variant Loader to a General Parser #95

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Refactored the Variant Loader to a General Parser #95

merged 5 commits into from
Dec 20, 2024

Conversation

MeAlam1
Copy link
Owner

@MeAlam1 MeAlam1 commented Dec 20, 2024

Description

Refactored the Variant Loader to use a general JSON parser. The parser is now designed to work independently, allowing users to parse and load custom JSON files outside of variants. This improves modularity and reusability across various components.

Changes

  • Change 1: Extracted the JSON parsing logic into a standalone general parser.
  • Change 2: Updated the Variant Loader to use the general JSON parser for loading variant data.
  • Change 3: Added support for external custom JSONs, allowing users to define and load their own JSON structures.

Type of Change

  • Bug fix
  • New feature
  • Cleanup
  • Breaking change
  • Documentation update

Checklist

@MeAlam1 MeAlam1 added Enhancement New feature or request 1.21 Minecraft Version NeoForge Mod Loader Fabric Mod Loader labels Dec 20, 2024
@MeAlam1 MeAlam1 added this to the 2.0.0 milestone Dec 20, 2024
@MeAlam1 MeAlam1 merged commit 5ca7771 into 1.21 Dec 20, 2024
3 checks passed
@MeAlam1 MeAlam1 deleted the V1.7.0 branch December 20, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21 Minecraft Version Enhancement New feature or request Fabric Mod Loader NeoForge Mod Loader
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant